Skip to content

more random tests #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

more random tests #1902

wants to merge 4 commits into from

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Oct 5, 2020

Just grabbed some low hanging fruit for test coverage while I was waiting to start a meeting 😁

@nlf nlf requested a review from a team as a code owner October 5, 2020 16:57
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes labels Oct 6, 2020
darcyclarke
darcyclarke approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@darcyclarke darcyclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

isaacs pushed a commit that referenced this pull request Oct 6, 2020
@nlf @isaacs
tests: tests for birthday command
f34595f 
PR-URL: #1902
Credit: @nlf
Close: #1902
Reviewed-by: @isaacs
@ruyadorno ruyadorno closed this Oct 6, 2020
@nlf nlf deleted the nlf/more-random-tests branch March 28, 2022 16:25
@Omrisnyk Omrisnyk mentioned this pull request Nov 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this pull request Dec 20, 2023
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 12, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Mar 22, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 29, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@darcyclarke darcyclarke darcyclarke approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlf @darcyclarke @ruyadorno